Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix api options for node v20.10.0 #1534

Merged
merged 1 commit into from Dec 6, 2023

Conversation

SethFalco
Copy link
Contributor

This is the proposed solution for your comment at:

The result of css-size changes depending on the Node.js version, so rather than testing for a specific number of bytes, this instead asserts that after processing, the result is fewer bytes.

In this scenario, on all Node.js versions except Node.js v20.10.0 (latest LTS release) it returns 67 B, but on v20.10.0 it returns 68 B instead. The new assertion instead asserts what, I assume, was the intent of the test, while passing on all Node.js versions.

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8511e5d) 97.56% compared to head (b2d6d8c) 97.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1534   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         123      123           
  Lines       10207    10207           
=======================================
  Hits         9958     9958           
  Misses        249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ludofischer ludofischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@ludofischer ludofischer merged commit 8eb75bf into cssnano:master Dec 6, 2023
16 checks passed
@SethFalco SethFalco deleted the fix/css-size-test branch December 6, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants