Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to svgo v3.0.5 and update docs #1533

Merged
merged 5 commits into from Dec 6, 2023

Conversation

SethFalco
Copy link
Contributor

@SethFalco SethFalco commented Dec 2, 2023

I've updated the documentation to use the SVGO v3 syntax, and upgraded to SVGO v3.0.5 which includes many bug fixes and a few more optimizations.

Consider reading the changelogs:

Does the following:

  • Update the documentation to use the SVGO v3 syntax, the original documentation was outdated.
  • Update to SVGO v3.0.5 which has many bug fixes and some optimizations.
  • Drop the types for the plugin property as SVGO provides its own already which is more elaborate.
  • Replace the link to the SVGO plugins directory in the GitHub repo with the link to the SVGO documentation.

Chores

  • Drop the Sticker Mule link from support page, as this link redirects to the homepage.

@ludofischer
Copy link
Collaborator

There's one test failure in the css-size package.

@SethFalco
Copy link
Contributor Author

SethFalco commented Dec 6, 2023

There's one test failure in the css-size package.

@ludofischer Hmm, seems to be specific to Node.js v20.10.0, and is not related to the changes introduced by this PR.

In all previous versions until then, the test passes as-is. Only when run in Node.js v20.10.0 which is the latest LTS release, both in CI and locally, the result changes to 68 B.

This is related to the Node.js version, though, and occurs in master and so should be affecting all PRs since 22 November 2023.

Since the result differs between versions, perhaps we can loosen the assertion to test for the intent of the test rather than a strict equality. For example, check the format of the message, or check that the value got smaller instead of comparing the exact size?

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8eb75bf) 97.56% compared to head (187dd5a) 97.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1533   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         123      123           
  Lines       10207    10207           
=======================================
  Hits         9958     9958           
  Misses        249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ludofischer ludofischer merged commit e24cbee into cssnano:master Dec 6, 2023
16 checks passed
@SethFalco SethFalco deleted the deps/svgo305 branch December 6, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants