feat: forward onRequestSent to handler (nodejs#2375)

crysmags · Feb 27, 2024 · 6123572 · 6123572
1 parent 04fbc08
commit 6123572
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/lib/core/request.js b/lib/core/request.js
@@ -222,6 +222,14 @@ class Request {
     if (channels.bodySent.hasSubscribers) {
       channels.bodySent.publish({ request: this })
     }
+
+    if (this[kHandler].onRequestSent) {
+      try {
+        this[kHandler].onRequestSent()
+      } catch (err) {
+        this.onError(err)
+      }
+    }
   }
 
   onConnect (abort) {

diff --git a/test/client-dispatch.js b/test/client-dispatch.js
@@ -671,6 +671,8 @@ test('dispatch onBodySent not a function', (t) => {
 })
 
 test('dispatch onBodySent buffer', (t) => {
+  t.plan(3)
+
   const server = http.createServer((req, res) => {
     res.end('ad')
   })
@@ -688,20 +690,24 @@ test('dispatch onBodySent buffer', (t) => {
       onBodySent (chunk) {
         t.equal(chunk.toString(), body)
       },
+      onRequestSent () {
+        t.pass()
+      },
       onError (err) {
         throw err
       },
       onConnect () {},
       onHeaders () {},
       onData () {},
       onComplete () {
-        t.end()
+        t.pass()
       }
     })
   })
 })
 
 test('dispatch onBodySent stream', (t) => {
+  t.plan(8)
   const server = http.createServer((req, res) => {
     res.end('ad')
   })
@@ -723,6 +729,9 @@ test('dispatch onBodySent stream', (t) => {
         t.equal(chunks[currentChunk++], chunk)
         sentBytes += Buffer.byteLength(chunk)
       },
+      onRequestSent () {
+        t.pass()
+      },
       onError (err) {
         throw err
       },
@@ -732,7 +741,7 @@ test('dispatch onBodySent stream', (t) => {
       onComplete () {
         t.equal(currentChunk, chunks.length)
         t.equal(sentBytes, toSendBytes)
-        t.end()
+        t.pass()
       }
     })
   })