Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: add limit for batch request items and response size #268

Open
wants to merge 2 commits into
base: release/v0.20.x-cronos
Choose a base branch
from

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jun 13, 2023

for more info: ethereum/go-ethereum#26681

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #268 (555f17f) into release/v0.20.x-cronos (0ea7b86) will decrease coverage by 0.04%.
The diff coverage is 27.77%.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           release/v0.20.x-cronos     #268      +/-   ##
==========================================================
- Coverage                   52.56%   52.52%   -0.04%     
==========================================================
  Files                         113      113              
  Lines                       11073    11095      +22     
==========================================================
+ Hits                         5820     5828       +8     
- Misses                       5006     5019      +13     
- Partials                      247      248       +1     
Impacted Files Coverage Δ
rpc/namespaces/ethereum/eth/filters/api.go 0.00% <0.00%> (ø)
x/evm/types/utils.go 62.16% <30.76%> (-10.57%) ⬇️
server/config/config.go 23.75% <50.00%> (+0.59%) ⬆️

@mmsqe mmsqe force-pushed the release/v0.20.x-cronos-batch-limit branch from 31c1bc3 to 555f17f Compare June 14, 2023 01:18
@@ -202,6 +203,7 @@ replace (
// use cosmos keyring
github.com/99designs/keyring => github.com/cosmos/keyring v1.1.7-0.20210622111912-ef00f8ac3d76
github.com/cosmos/cosmos-sdk => github.com/cosmos/cosmos-sdk v0.46.13-0.20230524145004-5b02d46853ba
github.com/ethereum/go-ethereum => github.com/mmsqe/go-ethereum v1.10.19-0.20230614011134-2cfbc432f7a5
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmsqe mmsqe marked this pull request as ready for review June 14, 2023 01:20
@mmsqe mmsqe requested a review from yihuang June 14, 2023 01:20
@yihuang
Copy link
Collaborator

yihuang commented Jun 14, 2023

这个是 v0.20.x-cronos的吗?

@mmsqe
Copy link
Collaborator Author

mmsqe commented Jun 14, 2023

这个是 v0.20.x-cronos的吗?

yea, and not sure if they can backport v1.10.19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants