Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Secret Store API and Client Implementation #379

Merged
merged 9 commits into from
Mar 22, 2023

Conversation

ezgidemirel
Copy link
Member

@ezgidemirel ezgidemirel commented Feb 2, 2023

Description of your changes

In this PR, we're introducing a gRPC server API for pluggable secret stores and adding the client implementation.

Fixes # https://github.com/upbound/team-control-planes/issues/922

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Consumed the change in Crossplane, provider-aws and ess-vault-plugin and tested it e2e
  • With unit tests

@ezgidemirel ezgidemirel force-pushed the ess branch 7 times, most recently from 4b6ca9d to 6497f2a Compare February 2, 2023 14:43
apis/common/v1/connection_details.go Outdated Show resolved Hide resolved
apis/common/v1/connection_details.go Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
Copy link
Member

@negz negz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done a full review, but this PR caught my eye so I've left a few suggestions. :)

apis/proto/v1alpha1/ess.proto Outdated Show resolved Hide resolved
apis/proto/v1alpha1/ess.proto Show resolved Hide resolved
apis/proto/v1alpha1/ess.proto Show resolved Hide resolved
apis/proto/v1alpha1/ess.proto Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
@ezgidemirel ezgidemirel force-pushed the ess branch 2 times, most recently from 8ac706f to bc202ba Compare March 9, 2023 12:37
@ezgidemirel ezgidemirel marked this pull request as ready for review March 10, 2023 09:24
pkg/connection/manager.go Outdated Show resolved Hide resolved
pkg/controller/options.go Outdated Show resolved Hide resolved
pkg/connection/manager.go Outdated Show resolved Hide resolved
apis/common/v1/connection_details.go Show resolved Hide resolved
apis/common/v1/connection_details.go Outdated Show resolved Hide resolved
apis/common/v1/connection_details.go Outdated Show resolved Hide resolved
apis/proto/v1alpha1/ess.proto Show resolved Hide resolved
pkg/certificates/certificates.go Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
pkg/connection/store/external/store.go Outdated Show resolved Hide resolved
pkg/certificates/fake/certs/ca.crt Outdated Show resolved Hide resolved
pkg/connection/manager_test.go Outdated Show resolved Hide resolved
pkg/connection/store/kubernetes/store.go Outdated Show resolved Hide resolved
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
Copy link
Member

@turkenh turkenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @ezgidemirel 💪

@turkenh turkenh merged commit 9c8fcc0 into crossplane:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants