Always terminate VM instead of shutting down.

This is more efficient and this will hopefully mitigate very frequent
freezing of VM during teardown
([#61](#61),
[#72](#72)).

changelog.md

@@ -14,6 +14,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
     has run. This adds a new input parameter: `shutdown_vm`. When set to `false`,
     this will hopefully mitigate very frequent freezing of VM during teardown ([#61](https://github.com/cross-platform-actions/action/issues/61), [#72](https://github.com/cross-platform-actions/action/issues/72)).
 
+### Changed
+- Always terminate VM instead of shutting down. This is more efficient and this
+    will hopefully mitigate very frequent freezing of VM during teardown
+    ([#61](https://github.com/cross-platform-actions/action/issues/61),
+    [#72](https://github.com/cross-platform-actions/action/issues/72)).
+
 ## [0.21.1] - 2023-11-03
 ### Fixed
 - FreeBSD jobs occasionally fail when ejecting the disk ([#64](https://github.com/cross-platform-actions/action/issues/64))

src/action/action.ts

@@ -112,10 +112,6 @@ export class Action {
       } finally {
         core.startGroup('Tearing down VM')
         await this.syncBack()
-
-        if (this.input.shutdownVm) {
-          await vm.stop()
-        }
       }
     } finally {
       try {

src/operating_systems/freebsd/qemu_vm.ts

@@ -11,8 +11,4 @@ export class QemuVm extends Vm {
       '-drive', `if=none,file=${this.configuration.resourcesDiskImage},id=drive1,cache=writeback,discard=ignore,format=raw`,
     ]
   }
-
-  protected override async shutdown(): Promise<void> {
-    await this.execute('sudo shutdown -p now')
-  }
 }

src/operating_systems/freebsd/xhyve_vm.ts

@@ -8,10 +8,6 @@ export class XhyveVm extends Vm {
     )
   }
 
-  protected override async shutdown(): Promise<void> {
-    await this.execute('sudo shutdown -p now')
-  }
-
   protected get networkDevice(): string {
     return 'virtio-net'
   }

src/operating_systems/netbsd/qemu_vm.ts

@@ -5,10 +5,6 @@ export class Vm extends QemuVm {
     return this.defaultHardDriveFlags
   }
 
-  protected override async shutdown(): Promise<void> {
-    await this.execute('sudo shutdown -h -p now')
-  }
-
   protected override get ipv6(): string {
     return 'ipv6=off'
   }

src/operating_systems/openbsd/qemu_vm.ts

@@ -8,8 +8,4 @@ export class QemuVm extends Vm {
   protected override get netDevive(): string {
     return this.architecture.networkDevice
   }
-
-  protected override async shutdown(): Promise<void> {
-    await this.execute('sudo shutdown -h -p now')
-  }
 }

src/operating_systems/openbsd/xhyve_vm.ts

@@ -9,10 +9,6 @@ export class XhyveVm extends Vm {
     )
   }
 
-  protected override async shutdown(): Promise<void> {
-    await this.execute('sudo shutdown -h -p now')
-  }
-
   protected get networkDevice(): string {
     return 'e1000'
   }

src/vm.ts

@@ -147,11 +147,6 @@ export abstract class Vm {
     )
   }
 
-  async stop(): Promise<void> {
-    core.info('Shuting down VM')
-    await this.shutdown()
-  }
-
   async terminate(): Promise<number> {
     core.info('Terminating VM')
     return await exec.exec(
@@ -175,10 +170,6 @@ export abstract class Vm {
     )
   }
 
-  protected async shutdown(): Promise<void> {
-    throw Error('Not implemented')
-  }
-
   async execute(
     command: string,
     options: ExecuteOptions = {}