Respect redirectURI #432
Open
Respect redirectURI #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures the redirectURI is respected even if RelayState was found in the acs parameters.
|
@crewjam does this update meet expectation? I didn't see a contributing guide so I wasn't sure what if anything I needed to include other than a PR. I appreciate you taking the time and looking at this. |
|
Hi, @bneil -- Can you help me understand what the issue is that you are trying to address? Also, it might be appropriate to add a test? |
|
@crewjam I ran into this interesting issue where RelatyState was being set to the wrong url. So I tried using the override url to correct that, however without this PR the override url is overwritten by RelayState. This PR allows either use cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the redirectURI is respected even if RelayState was found in the acs parameters.