Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Update language versions #111

Merged
merged 10 commits into from Nov 1, 2023
Merged

CI: Update language versions #111

merged 10 commits into from Nov 1, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Oct 30, 2023

About

Bump a few language versions on CI, where possible.

  • Java 11 vs. 17
  • PHP 8.3
  • Python 3.12
  • Ruby 3.2

/cc @hammerhead, @hlcianfagna, @karynzv, @WalBeh

aiohttp/_websocket.c:3042:53: error: ‘PyLongObject’ {aka ‘struct _longobject’} has no member named ‘ob_digit’
[...]

ERROR: Could not build wheels for aiohttp, which is required to install pyproject.toml-based projects
@amotl amotl requested review from seut and matriv October 31, 2023 16:23
@amotl amotl marked this pull request as ready for review October 31, 2023 16:29
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left comments about java version.

.github/workflows/testcontainers-java.yml Outdated Show resolved Hide resolved
.github/workflows/test-java-jooq.yml Outdated Show resolved Hide resolved
.github/workflows/test-java-jdbc.yml Outdated Show resolved Hide resolved
@amotl amotl requested a review from matriv November 1, 2023 10:53
@amotl amotl merged commit a425f91 into main Nov 1, 2023
29 checks passed
@amotl amotl deleted the amo/modernize branch November 1, 2023 11:08
os: [ "ubuntu-latest" ]
cratedb-version: [ "nightly" ]
os: [ 'ubuntu-latest' ]
java-version: [ '17', '21' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: why not adding 11 here as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants