Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): Add linux arm64 build to matrix #947

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smerle33
Copy link

@smerle33 smerle33 commented Mar 20, 2024

we (jenkins infra team) would like to use an ARM64 linux version of typos.
Reading this issue #828 and this PR #908 it sounds like it was just missing a build block for linux arm64 ... seem a little too easy but I did this at least to make my contribution to the task.

@epage
Copy link
Collaborator

epage commented Mar 20, 2024

A hack will need to be implemented to vet that this works in CI (since we don't run post-release on regular CI runs)

@smerle33 smerle33 changed the title feat(release): add linux arm64 build to matrix feat(release): Add linux arm64 build to matrix Mar 20, 2024
@smerle33
Copy link
Author

A hack will need to be implemented to vet that this works in CI (since we don't run post-release on regular CI runs)

I don't know much about this CI, but if this would have been to be tested within a PR (not the tag or build on main), I would have done a replay with the post-release step as a mandatory step but with staging filename or url, or even a manual sh step with the rust compilation command ....

May I be of any help to ease your process / tests ?

@epage
Copy link
Collaborator

epage commented Mar 20, 2024

post-release is skipped because it negatively impacts build times when few things change it. We could possibly filter to only run it if post-release itself is changing. So far, it hasn't been worth it because post-release doesn't change much.

@smerle33 smerle33 marked this pull request as ready for review March 20, 2024 14:43
@smerle33
Copy link
Author

hi @epage,
any input on the ability to provide an arm64 with or without this PR ?

Thanks for your time and help !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants