Test cpp linter#65 #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should analyze no files given the extensions are not used here
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Cpp-linter Review
Click here for the full clang-tidy patch
diff --git a/src/demo.cpp b/src/demo.cpp
index fc295c3..b160609 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -3 +3 @@
-#include <stdio.h>
+#include <cstdio>
@@ -4,0 +5,2 @@
+auto main() -> int
+{
@@ -6,6 +8,3 @@
-
-
-int main(){
-
- for (;;) break;
-
+ for (;;) {
+ break;
+ }
@@ -18 +17,2 @@ int main(){
- return 0;}
+ return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index a429f5c..2591c48 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -11 +11 @@ class Dummy {
- void *not_useful(char *str){useless = str;}
+ auto not_useful(char* str) -> void* { useless = str; }
Have any feedback or feature suggestions? Share it here.
| @@ -1,17 +1,18 @@ | |||
| /** This is a very ugly test code (doomed to fail linting) */ | |||
| #include "demo.hpp" | |||
| #include <cstdio> | |||
| #include <cstddef> | |||
| #include <stdio.h> | |||
There was a problem hiding this comment.
clang-tidy diagnostics
- inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers]
Suggested change
| #include <stdio.h> | |
| #include <cstdio> |
|
|
||
| // using size_t from cstddef | ||
| size_t dummyFunc(size_t i) { return i; } | ||
|
|
There was a problem hiding this comment.
clang-tidy suggestions
Suggested change
| auto main() -> int | |
| { |
Comment on lines
+6
to
+11
|
|
||
|
|
||
| int main(){ | ||
|
|
||
| for (;;) break; | ||
|
|
There was a problem hiding this comment.
clang-tidy diagnostics
- use a trailing return type for this function [modernize-use-trailing-return-type]
- statement should be inside braces [readability-braces-around-statements]
Suggested change
| int main(){ | |
| for (;;) break; | |
| for (;;) { | |
| break; | |
| } |
|
|
||
|
|
||
|
|
||
| return 0;} |
There was a problem hiding this comment.
clang-tidy suggestions
Suggested change
| return 0;} | |
| return 0; | |
| } |
| useless = str; | ||
| return 0; | ||
| } | ||
| void *not_useful(char *str){useless = str;} |
There was a problem hiding this comment.
clang-tidy diagnostics
- use a trailing return type for this function [modernize-use-trailing-return-type]
Suggested change
| void *not_useful(char *str){useless = str;} | |
| auto not_useful(char* str) -> void* { useless = str; } |
There was a problem hiding this comment.
Cpp-linter Review
Only 6 out of 7 clang-format suggestions fit within this pull request's diff.
Click here for the full clang-format patch
diff --git a/src/demo.cpp b/src/demo.cpp
index fc295c3..c522998 100644
--- a/src/demo.cpp
+++ b/src/demo.cpp
@@ -4,0 +5,2 @@
+int main()
+{
@@ -6,6 +8,2 @@
-
-
-int main(){
-
- for (;;) break;
-
+ for (;;)
+ break;
@@ -15,4 +13,2 @@ int main(){
-
-
-
- return 0;}
+ return 0;
+}
diff --git a/src/demo.hpp b/src/demo.hpp
index a429f5c..8f92cac 100644
--- a/src/demo.hpp
+++ b/src/demo.hpp
@@ -8 +8,5 @@ class Dummy {
- Dummy() :numb(0), useless("\0"){}
+ Dummy()
+ : numb(0)
+ , useless("\0")
+ {
+ }
@@ -11 +15 @@ class Dummy {
- void *not_useful(char *str){useless = str;}
+ void* not_useful(char* str) { useless = str; }
@@ -14,17 +17,0 @@ class Dummy {
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
@@ -34,2 +21 @@ struct LongDiff
- long diff;
-
+ long diff;
Have any feedback or feature suggestions? Share it here.
|
|
||
| // using size_t from cstddef | ||
| size_t dummyFunc(size_t i) { return i; } | ||
|
|
There was a problem hiding this comment.
clang-format suggestions
Suggested change
| int main() | |
| { |
Comment on lines
+6
to
+11
|
|
||
|
|
||
| int main(){ | ||
|
|
||
| for (;;) break; | ||
|
|
There was a problem hiding this comment.
clang-format suggestions
Suggested change
| int main(){ | |
| for (;;) break; | |
| for (;;) | |
| break; |
Comment on lines
+15
to
+18
|
|
||
|
|
||
|
|
||
| return 0;} |
There was a problem hiding this comment.
clang-format suggestions
Suggested change
| return 0;} | |
| return 0; | |
| } |
| @@ -5,12 +5,10 @@ | |||
| class Dummy { | |||
| char* useless; | |||
| int numb; | |||
| Dummy() :numb(0), useless("\0"){} | |||
There was a problem hiding this comment.
clang-format suggestions
Suggested change
| Dummy() :numb(0), useless("\0"){} | |
| Dummy() | |
| : numb(0) | |
| , useless("\0") | |
| { | |
| } |
| useless = str; | ||
| return 0; | ||
| } | ||
| void *not_useful(char *str){useless = str;} |
There was a problem hiding this comment.
clang-format suggestions
Suggested change
| void *not_useful(char *str){useless = str;} | |
| void* not_useful(char* str) { useless = str; } |
Comment on lines
34
to
35
| long diff; | ||
|
|
There was a problem hiding this comment.
clang-format suggestions
Suggested change
| long diff; | |
| long diff; |
There was a problem hiding this comment.
Cpp-linter Review
No objections from clang-format.
Great job! 🎉
Have any feedback or feature suggestions? Share it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests for cpp-linter/cpp-linter#65