-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR Review Suggestions #51
Merged
Merged
+1,524
−65
Commits on Jan 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for eb48a53 - Browse repository at this point
Copy the full SHA eb48a53View commit details -
support PR reviews for individual tool's output
satisfy some sonarcloud notes only get PR review info for actual PR events keep suggestions within 1 diff hunk - only dismiss reviews that can be dismissed - use default SHA for review commit_id - only use start_line if it precedes end line - use actual line numbers - prevent posting blank suggestions - don't add a new line at end of each suggestion - some code cleanup post review payload as json -- oops only create a Patch when creating a review use 1 review for both tools don't post reviews for PRs marked as "draft"
Configuration menu - View commit details
-
Copy full SHA for 35cac88 - Browse repository at this point
Copy the full SHA 35cac88View commit details -
Configuration menu - View commit details
-
Copy full SHA for a23cc35 - Browse repository at this point
Copy the full SHA a23cc35View commit details -
allow 2% drop (maximum) in coverage on CI checks
make patch coverage informational (not a gate)
Configuration menu - View commit details
-
Copy full SHA for 0cf2e5a - Browse repository at this point
Copy the full SHA 0cf2e5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9c449d - Browse repository at this point
Copy the full SHA e9c449dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 580d385 - Browse repository at this point
Copy the full SHA 580d385View commit details -
Configuration menu - View commit details
-
Copy full SHA for 455acc6 - Browse repository at this point
Copy the full SHA 455acc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30691d3 - Browse repository at this point
Copy the full SHA 30691d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34710e2 - Browse repository at this point
Copy the full SHA 34710e2View commit details -
reduce test permutations to only what is needed
Configuration menu - View commit details
-
Copy full SHA for ab15cc5 - Browse repository at this point
Copy the full SHA ab15cc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e889db - Browse repository at this point
Copy the full SHA 2e889dbView commit details
Commits on Jan 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 15d87a7 - Browse repository at this point
Copy the full SHA 15d87a7View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.