Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Review Suggestions #51

Merged
merged 12 commits into from
Jan 10, 2024
Merged

PR Review Suggestions #51

merged 12 commits into from
Jan 10, 2024

Commits on Jan 8, 2024

  1. Configuration menu
    Copy the full SHA
    eb48a53 View commit details
    Browse the repository at this point in the history
  2. support PR reviews for individual tool's output

    satisfy some sonarcloud notes
    
    only get PR review info for actual PR events
    
    keep suggestions within 1 diff hunk
    
    - only dismiss reviews that can be dismissed
    - use default SHA for review commit_id
    - only use start_line if it precedes end line
    - use actual line numbers
    - prevent posting blank suggestions
    - don't add a new line at end of each suggestion
    - some code cleanup
    
    post review payload as json -- oops
    
    only create a Patch when creating a review
    use 1 review for both tools
    don't post reviews for PRs marked as "draft"
    2bndy5 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    35cac88 View commit details
    Browse the repository at this point in the history
  3. add test

    2bndy5 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    a23cc35 View commit details
    Browse the repository at this point in the history
  4. allow 2% drop (maximum) in coverage on CI checks

    make patch coverage informational (not a gate)
    2bndy5 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    0cf2e5a View commit details
    Browse the repository at this point in the history
  5. handle odd hunk headers

    2bndy5 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    e9c449d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    580d385 View commit details
    Browse the repository at this point in the history
  7. reviewing the reviews

    2bndy5 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    455acc6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    30691d3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    34710e2 View commit details
    Browse the repository at this point in the history
  10. do not review closed PRs

    reduce test permutations to only what is needed
    2bndy5 committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    ab15cc5 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    2e889db View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Configuration menu
    Copy the full SHA
    15d87a7 View commit details
    Browse the repository at this point in the history