-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complete refactor #49
Merged
Commits on Jan 3, 2024
-
This uses a much more object-oriented approach. - Functions are properly organized in modules with appropriate names. - REST API usage is isolated in class derived from an abstract base class that will easily allow integrating other git servers' REST API. - clang-format output is filtered by lines (when applicable) as the XML is parsed. - The comment is made after all clang tool output is parsed. - All clang tool output is parsed from buffered strings (addresses #48). - There isn't any cached files when verbosity is not set to debug mode. - Tests can now use mocked HTTP requests (no more fear of hitting REST API rate limits). - Updated docs to reflect the new package structure.
Configuration menu - View commit details
-
Copy full SHA for 18afb38 - Browse repository at this point
Copy the full SHA 18afb38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69b45f2 - Browse repository at this point
Copy the full SHA 69b45f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82a0c69 - Browse repository at this point
Copy the full SHA 82a0c69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59b7f61 - Browse repository at this point
Copy the full SHA 59b7f61View commit details -
bring coverage back up to previously on main
only check format comment if checks failed not all versions of clang-format trigger on our test case for using a .clang-format config file
Configuration menu - View commit details
-
Copy full SHA for d14548d - Browse repository at this point
Copy the full SHA d14548dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24d437d - Browse repository at this point
Copy the full SHA 24d437dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ffbc3ed - Browse repository at this point
Copy the full SHA ffbc3edView commit details -
- merge run module into root __init__ module - did some doc review - CLI supports file paths/names given as positional args - added a test for this because the values are used as the starting value for the `not_ignored` list. - Change acceptable verbosity input values to be "debug" or "10" - Updated help strings in CLI for narrow terminals
Configuration menu - View commit details
-
Copy full SHA for 72a1664 - Browse repository at this point
Copy the full SHA 72a1664View commit details -
fix regression about filtering files changed
This reintroduces the approach where we filter the list of changed files according to diff information about lines-changed-only value. The advantage (which still holds true) is that we don't run a clang tool on a file if there is no changes of concern.
Configuration menu - View commit details
-
Copy full SHA for b703d37 - Browse repository at this point
Copy the full SHA b703d37View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb91239 - Browse repository at this point
Copy the full SHA bb91239View commit details
Commits on Jan 4, 2024
-
fix problem in "is ignored" logic
Due to python's lazy logic evaluation, we need to check if a path is first explicitly not-ignored before checking if said source is ignored. Also modified test to check sub directories and use files (not folders) in expected results.
Configuration menu - View commit details
-
Copy full SHA for aad7baf - Browse repository at this point
Copy the full SHA aad7bafView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.