Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete refactor #49

Merged
merged 11 commits into from
Jan 4, 2024
Merged

complete refactor #49

merged 11 commits into from
Jan 4, 2024

Commits on Jan 3, 2024

  1. complete refactor

    This uses a much more object-oriented approach.
    
    - Functions are properly organized in modules with appropriate names.
    - REST API usage is isolated in class derived from an abstract base class that will easily allow integrating other git servers' REST API.
    - clang-format output is filtered by lines (when applicable) as the XML is parsed.
    - The comment is made after all clang tool output is parsed.
    - All clang tool output is parsed from buffered strings (addresses #48).
    - There isn't any cached files when verbosity is not set to debug mode.
    - Tests can now use mocked HTTP requests (no more fear of hitting REST API rate limits).
    - Updated docs to reflect the new package structure.
    2bndy5 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    18afb38 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    69b45f2 View commit details
    Browse the repository at this point in the history
  3. prevent parsing blank XML strings

    and ensure they are decoded to UTF-8
    2bndy5 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    82a0c69 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    59b7f61 View commit details
    Browse the repository at this point in the history
  5. bring coverage back up to previously on main

    only check format comment if checks failed
    
    not all versions of clang-format trigger on our test case for using a .clang-format config file
    2bndy5 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    d14548d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    24d437d View commit details
    Browse the repository at this point in the history
  7. test post_feedback()

    should nearly complete code coverage
    2bndy5 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    ffbc3ed View commit details
    Browse the repository at this point in the history
  8. some more refactoring

    - merge run module into root __init__ module
    - did some doc review
    - CLI supports file paths/names given as positional args
    - added a test for this because the values are used as the starting value for the `not_ignored` list.
    - Change acceptable verbosity input values to be "debug" or "10"
    - Updated help strings in CLI for narrow terminals
    2bndy5 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    72a1664 View commit details
    Browse the repository at this point in the history
  9. fix regression about filtering files changed

    This reintroduces the approach where we filter the list of changed files according to diff information about lines-changed-only value.
    
    The advantage (which still holds true) is that we don't run a clang tool on a file if there is no changes of concern.
    2bndy5 committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    b703d37 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    bb91239 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. fix problem in "is ignored" logic

    Due to python's lazy logic evaluation, we need to check if a path is first explicitly not-ignored before checking if said source is ignored.
    
    Also modified test to check sub directories and use files (not folders) in expected results.
    2bndy5 committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    aad7baf View commit details
    Browse the repository at this point in the history