New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR review summary comment content #65
Comments
2bndy5
added a commit
that referenced
this issue
Feb 10, 2024
Merged
2bndy5
added a commit
that referenced
this issue
Feb 10, 2024
2bndy5
added a commit
that referenced
this issue
Feb 11, 2024
* resolves #65 This will remove the line "No objections from ..." when it is not relevant in PR review summary comments. Also adds a 🎉 for approved PR reviews * change logic about traversing advice for different tools * show cmd used to get fixes in logs * don't add quotes around extra-arg value * correct order of arg to post_feedback() use kwargs to avoid mis-ordering positional args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently a PR review from only clang-tidy will output:
Cpp-linter Review
No objections from clang-format.
Click here for the full clang-tidy patch
Have any feedback or feature suggestions? Share it here.
However, we don't need to alert users about info that is not requested. In this example, clang-format suggestions were not requested, but it still shows:
Furthermore, the full patch is included for any requested changes. This is because the suggested changes will not always fit within the diff. I have included the full patch in every review where changes are requested from the specified clang tool, even if all suggestions fit within the diff.
Proposal
Remove the "No objections from <clang-tool>" line for reviews with requested changes when the <clang-tool> was not enabled for PR reviews. Note, this info is still relevant for reviews in which the changes are approved.
The text was updated successfully, but these errors were encountered: