New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct colors about Alerter buttons #1989
Conversation
We have an order problem during the build concerning some css classes. Classes are imported before others, which causes style errors. In our case, some properties had to be overridden to keep the expected behavior in the app. That being said, the Alerter component seems old and not in accordance with the specifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peux-tu expliquer les pistes que tu as investiguées concernant le build stp ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to get the same behavior by forcing a higher CSS precedence instead of using !important
?
Maybe adding an alerter
class to the Alerter and then say : .alerter $button-alert--error
would be enough?
(sorry if you already tried this strategy)
generated from commit 1da555c
🎉 This PR is included in version 58.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Already tried @Ldoppea but it doesn't work unfortunately. |
Do we have an issue to get this problem in mind? Having added I really don't think this fix should be landed permanently in UI and we should have clear actions on what to do next to fix this issue. |
We have an order problem during the build concerning some css classes.
Classes are imported before others, which causes style errors.
In our case, some properties had to be overridden to keep the expected behavior in the app.
That being said, the Alerter component seems old and not in accordance with the specifications.