Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct colors about Alerter buttons #1989

Merged
merged 1 commit into from Dec 7, 2021
Merged

fix: Correct colors about Alerter buttons #1989

merged 1 commit into from Dec 7, 2021

Conversation

flohhhh
Copy link
Contributor

@flohhhh flohhhh commented Dec 7, 2021

We have an order problem during the build concerning some css classes.
Classes are imported before others, which causes style errors.

In our case, some properties had to be overridden to keep the expected behavior in the app.

That being said, the Alerter component seems old and not in accordance with the specifications.

We have an order problem during the build concerning some css classes.
Classes are imported before others, which causes style errors.

In our case, some properties had to be overridden to keep the expected
behavior in the app.

That being said, the Alerter component seems old and not in accordance
with the specifications.
Copy link
Collaborator

@JF-Cozy JF-Cozy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peux-tu expliquer les pistes que tu as investiguées concernant le build stp ?

Copy link
Member

@Ldoppea Ldoppea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to get the same behavior by forcing a higher CSS precedence instead of using !important?

Maybe adding an alerter class to the Alerter and then say : .alerter $button-alert--error would be enough?

(sorry if you already tried this strategy)

@flohhhh
Copy link
Contributor Author

flohhhh commented Dec 7, 2021

I followed these leads regarding the build order. #1, #2 and #3. There is a lot of information in it.

I tried to gradually upgrade mini-css-extract-plugin but didn't get the expected result.

@flohhhh flohhhh merged commit 1da555c into master Dec 7, 2021
@flohhhh flohhhh deleted the fix/alerter branch December 7, 2021 11:05
cozy-bot pushed a commit that referenced this pull request Dec 7, 2021
@cozy-bot
Copy link

cozy-bot commented Dec 7, 2021

🎉 This PR is included in version 58.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@flohhhh
Copy link
Contributor Author

flohhhh commented Dec 7, 2021

Already tried @Ldoppea but it doesn't work unfortunately.

@Crash--
Copy link
Contributor

Crash-- commented Dec 8, 2021

We have an order problem during the build concerning some css classes.
Classes are imported before others, which causes style errors.

Do we have an issue to get this problem in mind? Having added !important in the stylus means that now we can't use anymore our utilities method with this component.

I really don't think this fix should be landed permanently in UI and we should have clear actions on what to do next to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants