Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Chokidar to v3.5.2 #2107

Merged
merged 1 commit into from Jul 6, 2021
Merged

Bump Chokidar to v3.5.2 #2107

merged 1 commit into from Jul 6, 2021

Conversation

taratatach
Copy link
Member

@taratatach taratatach commented Jul 6, 2021

Upgrading Chokidar leads to an upgrade of fsevents (i.e. one of
Chokidar's own dependencies) which received a fix in v2.3.2 preventing
crashes we see in our tests on macOS, especially when run in Github
Actions.

See fsevents/fsevents#355 for more info.

Please make sure the following boxes are checked:

  • PR is not too big
  • it improves UX & DX in some way
  • it includes unit tests matching the implementation changes
  • it includes scenarios matching a new behaviour or has been manually tested
  • it includes relevant documentation

  Upgrading Chokidar leads to an upgrade of `fsevents` (i.e. one of
  Chokidar's own dependencies) which received a fix in v2.3.2 preventing
  crashes we see in our tests on macOS, especially when run in Github
  Actions.
@taratatach taratatach self-assigned this Jul 6, 2021
@taratatach taratatach merged commit af09ec9 into master Jul 6, 2021
@taratatach taratatach deleted the deps/upgrade-chokidar branch July 6, 2021 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant