Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deadlog in Coverlet.Integration.Tests.BaseTest #1541

Merged
merged 5 commits into from Oct 11, 2023
Merged

fix deadlog in Coverlet.Integration.Tests.BaseTest #1541

merged 5 commits into from Oct 11, 2023

Conversation

Bertk
Copy link
Collaborator

@Bertk Bertk commented Oct 10, 2023 •
edited

  • avoid deadlocks, use an asynchronous read operation on at least one of the streams (Process.StandardOutput + Process.StandaradError)
  • use project names for test artifacts (trx, html)
  • use CopyFiles instead of powershell script (publish-coverlet-result-files.yml)
  • disable CPM for coverlet.core.tests.csproj (VS reports "restore loop")

@Bertk Bertk marked this pull request as ready for review October 10, 2023 10:50
daveMueller
daveMueller approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@daveMueller daveMueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All cool, LGTM 👍

@daveMueller daveMueller merged commit 89f2f3e into coverlet-coverage:master Oct 11, 2023
8 checks passed
@Bertk Bertk deleted the fix-test-deadlock branch October 11, 2023 07:18
@Bertk Bertk changed the title fix deadlog in BaseTest fix deadlog in Coverlet.Integration.Tests.BaseTest Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveMueller daveMueller daveMueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Bertk @daveMueller