Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coverlet.msbuild.tasks unit tests #1534

Merged
merged 15 commits into from
Oct 19, 2023

Conversation

Bertk
Copy link
Collaborator

@Bertk Bertk commented Sep 15, 2023

  • add CoverageResultTaskTests.cs for coverlet.msbuild.tasks unit test
  • allows local debugging of msbuild tasks
  • removes system.console output in ReportWriter (potential conflicts - msbuild task logging)

@Bertk Bertk marked this pull request as ready for review September 16, 2023 06:37
@Bertk
Copy link
Collaborator Author

Bertk commented Sep 16, 2023

The CI build fails with /p:CollectCoverage=true and my local test execution fails with a different message

image

Everything is fine without /p:CollectCoverage=true.

... and suddenly the CI does not show test errors anymore with enabled code coverage.

@Bertk Bertk force-pushed the msbuild-unit-tests branch 2 times, most recently from 4802104 to 0a9bcb8 Compare September 16, 2023 08:05
@Bertk Bertk marked this pull request as draft September 17, 2023 09:34
@Bertk Bertk marked this pull request as ready for review September 17, 2023 12:48
Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see formatting and updates, maybe it's better avoid to format here and add only tests to make the review easier, we could lose some small detail

@Bertk
Copy link
Collaborator Author

Bertk commented Sep 21, 2023

I see formatting and updates, maybe it's better avoid to format here and add only tests to make the review easier, we could lose some small detail

This is will be fixed with the other PR #1529 . The source code files are not in sync with the current definitions of .editorconfig. By the way, the format on save VS feature cannot be used until the source files are harmonized.

https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/csharp-formatting-options

Copy link
Collaborator

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM wait for @daveMueller green light

Directory.Build.props Show resolved Hide resolved
eng/build.yml Outdated Show resolved Hide resolved
eng/azure-pipelines.yml Outdated Show resolved Hide resolved
src/coverlet.msbuild.tasks/CoverageResultTask.cs Outdated Show resolved Hide resolved
@Bertk
Copy link
Collaborator Author

Bertk commented Oct 15, 2023

@daveMueller By the way, could you please check whether mandatory checks are defined? Otherwise a PR with a broken build pipeline could be merged.

This configuration is available in Settings->branches->branch protection

image

@daveMueller
Copy link
Collaborator

@daveMueller By the way, could you please check whether mandatory checks are defined? Otherwise a PR with a broken build pipeline could be merged.

This configuration is available in Settings->branches->branch protection
image

Sorry I also don't have permission to look into that. Maybe @MarcoRossignoli can? But I'm pretty sure that PRs with a failed build job can't be merged.

Copy link
Collaborator

@daveMueller daveMueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Bertk 🙏

@daveMueller daveMueller merged commit cceb71d into coverlet-coverage:master Oct 19, 2023
8 checks passed
@Bertk Bertk deleted the msbuild-unit-tests branch October 20, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants