Align github and nuget release versions

[daveMueller]

closes #1122
closes #1413

[daveMueller]

I'm not sure about how the tag for the github release is created? Even though I change the AssemblyVersion in coverlet.core.csproj the assembly itself gets the number specified in version.json.

I'm also not really able to see how or if coverlets' azure pipeline is setting the release tag? Doesn't seem so. Is the github release created manually? @MarcoRossignoli @petli
Then what is the reason for the AssemblyVersion in coverlet.core.cspro at all? Couldn't we just drop it?

[MarcoRossignoli]

I'm not sure about how the tag for the github release is created?

I'm creating it manually today using the version inside src/coverlet.core/coverlet.core.csproj

I'm also not really able to see how or if coverlets' azure pipeline is setting the release tag?

we're using this manual workflow to release https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/ReleasePlan.md#how-to-manually-release-packages-to-nugetorg with Nerdbank.GitVersioning https://github.com/dotnet/Nerdbank.GitVersioning

The nightly is generated using @tonerdo pipeline and the setup is here https://github.com/coverlet-coverage/coverlet/blob/master/eng/azure-pipelines-nightly.yml

[daveMueller]

Thanks @MarcoRossignoli. I think I have everything ready now. I already checked the pipelines and it seems that they also don't use the version in src/coverlet.core/coverlet.core.csproj. Thus I think it's safe to just drop it.

[daveMueller]

/azp run

[azure-pipelines]

Commenter does not have sufficient privileges for PR 1416 in repo coverlet-coverage/coverlet

[MarcoRossignoli]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).