Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeLoadException for certain combinations with Microsoft.Extensions.DependencyInjection 6.0.1 #1395

Merged
merged 2 commits into from
Oct 27, 2022
Merged

TypeLoadException for certain combinations with Microsoft.Extensions.DependencyInjection 6.0.1 #1395

merged 2 commits into from
Oct 27, 2022

Conversation

daveMueller
Copy link
Collaborator

@daveMueller daveMueller commented Oct 21, 2022 •
edited

closes #1390

@daveMueller
removed reference of Microsoft.Extensions.DependencyInjection.Abstrac…
76a423e 
…tions and update of Microsoft.Extensions.DependencyInjection
@daveMueller
nit
c7363b1
@candritzky
Copy link

@daveMueller My expectation was that this would be fixed by lifting the TargetFramework of coverlet.console.csproj from net5.0 to net6.0. Maybe it's worth also looking into this.

@daveMueller
Copy link
Collaborator Author

Yes I thought about that but the issue also happend for the coverlet.collector driver. coverlet.collector and coverlet.core are both netstandard2.0. The collector is totally independent from the global tool and thus it can't be related to net5.0.

@daveMueller daveMueller marked this pull request as ready for review October 21, 2022 05:46
petli
petli approved these changes Oct 21, 2022
View reviewed changes
Copy link
Collaborator

@petli petli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a simple fix!

@cristipufu
Copy link

Thanks for the fix! When can we expect it merged & released?

@petli petli merged commit 32bcff1 into coverlet-coverage:master Oct 27, 2022
@petli
Copy link
Collaborator

petli commented Oct 27, 2022

I've merged so it should make it into the nightly builds now, at least:
https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/ConsumeNightlyBuild.md

@petli petli mentioned this pull request Oct 27, 2022
Merged
@daveMueller daveMueller deleted the 1390_TypeLoadException branch September 12, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petli petli petli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeLoadException error (DependencyInjection) with latest EFCore
4 participants
@daveMueller @candritzky @cristipufu @petli