Skip fsharp construct with unknown source
#1165
Conversation
| Document document = metadataReader.GetDocument(docHandle); | ||
| string docName = _sourceRootTranslator.ResolveFilePath(metadataReader.GetString(document.Name)); | ||
|
|
||
| Guid languageGuid = metadataReader.GetGuid(document.Language); | ||
| // We verify all docs and return false if not all are present in local | ||
| // We could have false negative if doc is not a source | ||
| // Btw check for all possible extension could be weak approach | ||
| // We exlude from the check the autogenerated source file(i.e. source generators) | ||
| if (!_fileSystem.Exists(docName) && !docName.EndsWith(".g.cs")) | ||
| // We exclude from the check the autogenerated source file(i.e. source generators) | ||
| // We exclude special F# construct https://github.com/coverlet-coverage/coverlet/issues/1145 | ||
| if (!_fileSystem.Exists(docName) && !docName.EndsWith(".g.cs") && !IsUnknownModuleInFSharpAssembly(languageGuid, docName)) |
There was a problem hiding this comment.
This logic could be extracted into a method, since it is identical with the logic in PortablePdbHasLocalSource. This helps if we need to add even more exceptions, e.g. for the null documents in VB (#1073).
test/Directory.Build.props
Outdated
| <Choose> | ||
| <When Condition="$(MSBuildProjectName)!='coverlet.tests.projectsample.fsharp'"> | ||
| <PropertyGroup> | ||
| <IsTestProject>true</IsTestProject> |
There was a problem hiding this comment.
Can you force false directly on new project coverlet.tests.projectsample.fsharp.fsproj ?
Or in future we need to add every time projects here.
There was a problem hiding this comment.
Yes sorry didn't think about this. I was getting a error when dotnet test the fsharp project and I didn't know why.
Took me a good amount of time to figure out it is the Directory.Build.pros. The other c# class library projects don't have this issue even when <IsTestProject>true</IsTestProject>. Seems to be a fsharp issue.
| using Moq; | ||
| using Coverlet.Core.Abstractions; | ||
|
|
||
| namespace Coverlet.Core.Helpers.Tests | ||
| { | ||
| public class InstrumentationHelperTests | ||
| { | ||
| private readonly InstrumentationHelper _instrumentationHelper = | ||
| private InstrumentationHelper _instrumentationHelper = |
There was a problem hiding this comment.
I prefer keep this readonly and define new one only for that test wdym?
Like you did in CanInstrumentFSharpAssemblyWithAnonymousRecord
# Conflicts: # Documentation/Changelog.md
closes #1145