Be sure to open the hitfile with read access. (#1214)

Be sure to open the hitfile with read access.
coverlet-coverage · Sep 9, 2021 · 8f91b34 · 8f91b34
1 parent 468b632
commit 8f91b34
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/coverlet.core/Coverage.cs b/src/coverlet.core/Coverage.cs
@@ -408,7 +408,7 @@ private void CalculateCoverage()
                 }
 
                 var documentsList = result.Documents.Values.ToList();
-                using (var fs = _fileSystem.NewFileStream(result.HitsFilePath, FileMode.Open))
+                using (var fs = _fileSystem.NewFileStream(result.HitsFilePath, FileMode.Open, FileAccess.Read))
                 using (var br = new BinaryReader(fs))
                 {
                     int hitCandidatesCount = br.ReadInt32();
@@ -442,8 +442,15 @@ private void CalculateCoverage()
                     }
                 }
 
-                _instrumentationHelper.DeleteHitsFile(result.HitsFilePath);
-                _logger.LogVerbose($"Hit file '{result.HitsFilePath}' deleted");
+                try
+                {
+                    _instrumentationHelper.DeleteHitsFile(result.HitsFilePath);
+                    _logger.LogVerbose($"Hit file '{result.HitsFilePath}' deleted");
+                }
+                catch (Exception ex)
+                {
+                    _logger.LogWarning($"Unable to remove hit file: {result.HitsFilePath} because : {ex.Message}");
+                }
             }
         }