Fix aarch binaries download url
#399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xRuiAlves
commented
Apr 20, 2023
There was a problem hiding this comment.
Leaving a couple of comments to help guiding the review.
This should be a straightforward and easy fix, let me know what you think @alexarchambault :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like that from version v2.1.0-RC4 forwards the coursier
aarch64binaries were moved from https://github.com/coursier/coursier repository to https://github.com/VirtusLab/coursier-m1.This, unfortunately, invalidates the previously added
aarch64support previously added for versions>= v2.1.1.Fixing this by changing the target download URL based on the processor architecture!