Add support for aarch64
#369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that we also have a concept of 'architecture' now, renaming 'arc' to 'archive' for the sake of clarity.
xRuiAlves
commented
Mar 13, 2023
| const arc = `${guid}.gz` | ||
| await cli.exec('mv', [guid, arc]) | ||
| csBinary = arc | ||
| const archive = `${guid}.gz` |
There was a problem hiding this comment.
Renamed these arc variables to archive - With the introduction of the new architecture variable, arc could be ambiguous, and the renaming enhances clarity on this.
|
Additionally, I've refactored the action logic to make use of the system's |
|
Hey @alexarchambault! Was wondering if you had a chance to taking a look at this in the past few weeks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the setup action only supports the
x86_64architecture.coursieralso publishes binaries foraarch64(e.g., v2.1.0-RC4).Leveraging the system's
process.archto choose which file architecture to download.