add buf support to repo #126
Merged
+431
−320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
force-pushed
the
marko/buf
branch
from
cb4495b to
239b335
Compare
Codecov ReportBase: 50.34% // Head: 38.11% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
===========================================
- Coverage 50.34% 38.11% -12.23%
===========================================
Files 23 5 -18
Lines 7886 4182 -3704
Branches 85 0 -85
===========================================
- Hits 3970 1594 -2376
+ Misses 3560 2275 -1285
+ Partials 356 313 -43
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
julienrbrt
reviewed
Nov 30, 2022
Makefile
Outdated
| @$(protoImage) buf lint --error-format=json | ||
|
|
||
| proto-check-breaking: | ||
| @$(protoImage) buf breaking --against $(HTTPS_GIT)#branch=main |
There was a problem hiding this comment.
You need to set HTTPS_GIT as a variable and update the branch to master.
tac0turtle
commented
Nov 30, 2022
| - uses: bufbuild/buf-push-action@v1 | ||
| with: | ||
| input: "proto" | ||
| buf_token: ${{ secrets.BUF_TOKEN }} |
julienrbrt
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds buf support and Golang/Rust generation script