Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: upgrade golang.org/x/exp to latest #83

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

prasincs
Copy link
Contributor

@prasincs prasincs commented Aug 7, 2023

Recently golang.org/x/exp package decided to change function signature for SortFunc to align better with cmp package
reasoning is here:
golang/go#60091 (comment)

this is likely going to be standard for Go 1.21 and going forward

@prasincs prasincs requested a review from a team as a code owner August 7, 2023 23:48
@prasincs prasincs changed the title Upgrade golang.org/x/exp to latest chore: Upgrade golang.org/x/exp to latest Aug 7, 2023
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@julienrbrt
Copy link
Member

Given that people when depending on cosmos/gogoproto and trying to bump to latest pseudo version of golang.org/x/exp will currently get an error. I think it is worth a changelog.

@julienrbrt julienrbrt changed the title chore: Upgrade golang.org/x/exp to latest refactor!: upgrade golang.org/x/exp to latest Aug 17, 2023
@julienrbrt julienrbrt merged commit 19fa753 into cosmos:main Aug 17, 2023
4 checks passed
beer-1 added a commit to initia-labs/cosmos-sdk that referenced this pull request Dec 8, 2023
beer-1 added a commit to initia-labs/cosmos-sdk that referenced this pull request Dec 8, 2023
beer-1 added a commit to initia-labs/cosmos-sdk that referenced this pull request Dec 8, 2023
beer-1 added a commit to initia-labs/cosmos-sdk that referenced this pull request Dec 8, 2023
beer-1 added a commit to initia-labs/cosmos-sdk that referenced this pull request Dec 8, 2023
beer-1 added a commit to initia-labs/cosmos-sdk that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants