Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oidc: restrict use of context.Background() #364

Merged
merged 1 commit into from Feb 4, 2023
Merged

oidc: restrict use of context.Background() #364

merged 1 commit into from Feb 4, 2023

Conversation

ericchiang
Copy link
Collaborator

This causes NewRemoteKeySet not to detach the context, and adds a method to create a verifier with an explicit context:

func (*Provider) VerifierContext(context.Context, *Config) *IDTokenVerifier

Fixes #339?

@ericchiang ericchiang mentioned this pull request Jan 13, 2023
Closed
@nic
Copy link

nic commented Feb 1, 2023

LGTM

@ericchiang ericchiang merged commit 2936eb3 into coreos:v3 Feb 4, 2023
@ericchiang ericchiang deleted the ctx branch March 3, 2023 07:26
@zakcutner zakcutner mentioned this pull request Apr 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nic nic nic approved these changes

@argenta-quanto argenta-quanto argenta-quanto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-obvious behavior with long lived oidc.Provider objects: remoteKeySet caches original context
3 participants
@ericchiang @nic @argenta-quanto