add private network to network enum #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuly14
reviewed
Aug 15, 2023
Comment on lines
-29
to
-33
| // We don't derive Serialize because it is manually implemented using AsRef<str> and it would | ||
| // break a lot of things since Serialize is `kebab-case` vs Deserialize `snake_case`. | ||
| // This means that the Network type is not "round-trippable", because the Serialize and Deserialize | ||
| // implementations do not use the same case style. | ||
|
|
There was a problem hiding this comment.
Did you find out why is this the case? It doesn't really make sense to me to make the network type not "round-trippable"
There was a problem hiding this comment.
not sure about that, but thats what I found about this
gakonst/ethers-rs#2038 (comment)
gakonst/ethers-rs#2268 (comment)
https://github.com/gakonst/ethers-rs/pull/2270/files
Seems like it was hot-fixed and tests for "round-trippable" were added
…n/corebc-rs into feature/private_network
…n/corebc-rs into feature/private_network
|
Also I removed utils::NetworkType and replaced it with types::Network. The same logic was written twice. |
Kuly14
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.