Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warn instead of returning error on empty glob result (#1280) #1281

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jcchavezs
Copy link
Member

@jcchavezs jcchavezs commented Jan 9, 2025

Despite #1259 being the right thing from user experience, it was a breaking change, hence turning into a warning to not to break existing behaviour.

Fixes #1280 cc @nimasamii

Thanks for your contribution ❤️

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
jcchavezs José Carlos Chávez
@jcchavezs jcchavezs requested a review from a team as a code owner January 9, 2025 10:07
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.76%. Comparing base (779742f) to head (883ba10).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1281   +/-   ##
=======================================
  Coverage   81.76%   81.76%           
=======================================
  Files         169      169           
  Lines        9770     9770           
=======================================
  Hits         7988     7988           
  Misses       1533     1533           
  Partials      249      249           
Flag Coverage Δ
coraza.rule.case_sensitive_args_keys 81.71% <100.00%> (ø)
coraza.rule.multiphase_valuation 81.76% <100.00%> (ø)
coraza.rule.no_regex_multiline 81.69% <100.00%> (ø)
default 81.76% <100.00%> (ø)
examples+ 16.54% <0.00%> (ø)
examples+coraza.rule.case_sensitive_args_keys 81.71% <100.00%> (ø)
examples+coraza.rule.multiphase_valuation 81.59% <100.00%> (ø)
examples+coraza.rule.no_regex_multiline 81.61% <100.00%> (ø)
examples+memoize_builders 81.71% <100.00%> (ø)
examples+no_fs_access 81.04% <100.00%> (ø)
ftw 81.76% <100.00%> (ø)
memoize_builders 81.85% <100.00%> (ø)
no_fs_access 81.20% <100.00%> (ø)
tinygo 81.72% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jcchavezs jcchavezs merged commit f4de57c into main Jan 9, 2025
71 checks passed
@jcchavezs jcchavezs deleted the 1280_fix branch January 9, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty glob should show a warning not error
2 participants