EAC-33430 Add request signing to SLO requests #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1213,6 +1212,9 @@ func (sp *ServiceProvider) MakeLogoutRequest(idpURL, nameID string) (*LogoutRequ | |||
| SPNameQualifier: sp.Metadata().EntityID, | |||
| }, | |||
| } | |||
| if sessionID != "" { | |||
| req.SessionIndex = &SessionIndex{Value: sessionID} | |||
There was a problem hiding this comment.
need to include this so IDP can reference our "external" session ID
dejan-lokar
approved these changes
Mar 27, 2024
| @@ -1251,21 +1256,42 @@ func (r *LogoutRequest) Redirect(relayState string) *url.URL { | |||
|
|
|||
| rv, _ := url.Parse(r.Destination) | |||
|
|
|||
| query := rv.Query() | |||
| query.Set("SAMLRequest", w.String()) | |||
| query := rv.RawQuery | |||
There was a problem hiding this comment.
Are you intentionally building URL query manually?
There was a problem hiding this comment.
It came from the solution from github issue.
There's some base64 -> url encoding that will likely causes problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sign SLO requests
Different request being signed: https://github.com/cookieai-jar/saml/blob/main/service_provider.go#L249
Github issue containing working solution: crewjam#550