Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing conditions param for moduleResolve #3962

Merged
merged 2 commits into from Mar 7, 2024

Conversation

JounQin
Copy link
Contributor

@JounQin JounQin commented Mar 7, 2024

Description

related wooorm/import-meta-resolve#24

Motivation and Context

It fixes a possible issue when using a dual-package config, without this change, commonjs entry could be resolved, with this change, ESM entry will be preferred correctly.

Usage examples

// commitlint.config.js
module.exports = {};
echo "your commit message here" | commitlint # fails/passes

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@escapedcat escapedcat merged commit 67baff9 into conventional-changelog:master Mar 7, 2024
6 checks passed
@JounQin JounQin deleted the fix/conditions branch March 7, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants