Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config-nx-scopes): support latest nx version #3728

Merged
merged 2 commits into from
Oct 26, 2023
Merged

feat(config-nx-scopes): support latest nx version #3728

merged 2 commits into from
Oct 26, 2023

Conversation

clemenscodes
Copy link
Contributor

Add nx v17 to peer dependencies of @commitlint/config-nx-scopes

Description

  • Add version ^17.0.0 to peer dependencies
  • Add fixture nx17 with packages g and h

Motivation and Context

fixes #3727

How Has This Been Tested?

  • Add test for this fixture to index.test.js

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@clemenscodes
fix(commitlint-config-nx-scopes): support nx version 17
8db9d3e 
updated peer dependencies to support nx version 17
@clemenscodes
refactor(commitlint-config-nx-scopes): follow package name convention
5ea0525 
renamed packages in fixtures to follow the subsequent name convention
@clemenscodes clemenscodes changed the title fix(config-nx-scopes): support latest nx version feat(config-nx-scopes): support latest nx version Oct 26, 2023
@escapedcat escapedcat merged commit 22e6f74 into conventional-changelog:master Oct 26, 2023
3 checks passed
@commit-lint commit-lint bot mentioned this pull request Oct 26, 2023
Merged
@escapedcat
Copy link
Member

https://github.com/conventional-changelog/commitlint/releases/tag/v18.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(config-nx-scopes): bump nx peer dependency to latest version
2 participants
@clemenscodes @escapedcat