Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove build on any branches except main and tags #3674

Merged
merged 1 commit into from Oct 3, 2023

Conversation

shanduur
Copy link
Contributor

@shanduur shanduur commented Oct 3, 2023

Description

Build and push only releases and master branch (via cron).

Motivation and Context

Right now every branch that is created in the repo triggers build in the repository. This includes branches created by Renovate. We don't want it - only master (via cron) and releases should be built

Usage examples

N/A

How Has This Been Tested?

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Mateusz Urbanek <mateusz.urbanek.98@gmail.com>
@shanduur shanduur mentioned this pull request Oct 3, 2023
13 tasks
Copy link
Member

@AdeAttwood AdeAttwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need this on the master branch for the edge tag. Its only feature, branches we don't want.

@shanduur
Copy link
Contributor Author

shanduur commented Oct 3, 2023

@AdeAttwood but previously you had '!master' - meaning exclude master from builds.

@shanduur
Copy link
Contributor Author

shanduur commented Oct 3, 2023

Cron job is started on default branch (in this case master) and it will be tagged as edge - no need to explicitly mention it in the workflow.

@escapedcat
Copy link
Member

@kaiehrhardt wdyt?

@AdeAttwood
Copy link
Member

@escapedcat good to go when you are.

@escapedcat
Copy link
Member

Thanks @shanduur !

@escapedcat escapedcat merged commit cfc647f into conventional-changelog:master Oct 3, 2023
5 checks passed
@shanduur shanduur deleted the patch-1 branch October 3, 2023 12:31
@kaiehrhardt
Copy link
Contributor

sorry for the late response. no ci tests for the docker image build? :'(
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request could be an option, i think.

@escapedcat
Copy link
Member

sorry for the late response.

No worries, happy with any time you want to spend here.

no ci tests for the docker image build? :'( https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request could be an option, i think.

Anyone up for a PR? :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants