Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify subject-case [resolves #3638] #3640

Merged

Conversation

olets
Copy link
Contributor

@olets olets commented Aug 9, 2023

Description

resolves #3638

  1. subject-case uses the standard condition language
  2. subject-case "possible values" to use // lower case instead of // default

Motivation and Context

Usage examples

N/A

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Sorry, something went wrong.

@escapedcat
Copy link
Member

Didn't check the details now but is the "default" info somehow relevant if you use this rule without a specific value?

@olets
Copy link
Contributor Author

olets commented Aug 15, 2023

@escapedcat as far as I've seen, no. In config-angular (link) and config-conventional (link) the default value is

['sentence-case', 'start-case', 'pascal-case', 'upper-case']

as already correctly documented at docs/reference-rules.md:286

@escapedcat
Copy link
Member

Thanks

@escapedcat escapedcat merged commit a6989b2 into conventional-changelog:master Aug 16, 2023
@matz3
Copy link

matz3 commented Mar 11, 2024

But isn't the rule incorrect in the docs? It's always but in the code it's never

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

docs: clarify subject-case
3 participants