Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add compatibility for Nx 16 #3589

Merged
merged 1 commit into from
May 7, 2023

Conversation

fguitton
Copy link
Contributor

Description

This is still a work in progress until Nx 16 release (anytime now)
This PR adjusts the package.json Nx compatibility for commitlint and move tests for Nx 14 and Nx 15 separately. This is due to changes in the packages name for Nx from @nrwl/* to @nx/*

Motivation and Context

Nx is about to push version 16.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

@fguitton fguitton force-pushed the chore/nx-16 branch 4 times, most recently from 318ccd0 to 03d2ab1 Compare April 23, 2023 21:35
@escapedcat
Copy link
Member

Thanks for taking care of this!

@fguitton fguitton marked this pull request as ready for review May 6, 2023 14:32
@fguitton
Copy link
Contributor Author

fguitton commented May 7, 2023

@escapedcat This should be ready now 😝

While Nx 16 provides virtually full compatibility with Nx 15 it has deprecated numerous internal structures and commitlint will need to move away from using the Workspace provider to extract scopes. I will try to get a PR out when I can find some time.

There is also perhaps the topic of Lerna, which is basically just Nx under the hood nowadays. Perhaps some unifying would be in order ?

@escapedcat escapedcat merged commit b335b83 into conventional-changelog:master May 7, 2023
@escapedcat
Copy link
Member

Thanks @fguitton !

There is also perhaps the topic of Lerna, which is basically just Nx under the hood nowadays. Perhaps some unifying would be in order ?

Happy for any suggestions. The lerna package still seems to be quite popular.

@fguitton fguitton deleted the chore/nx-16 branch May 9, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants