Clean up some warnings #2010
Merged
Clean up some warnings #2010
+31
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
"default case should be first or last in switch statement (ST1015)" Only moves unchanged code, should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Should not change behavior. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Conceptually, these read from the network and _should_ be interruptible. But we could, at best, interrupt the wait on the channels returned by GetBlobAt; we would then still get a ReadCloser where we can call Read() but not concurrently notice a cancellation. The cancellation needs to happen at the HTTP client side, i.e. inside the c/image private.ImageSourceInternalOnly.GetBlobAt call (not ImageSourceSeekable), and, although it seems not to be quite documented, the http stack's http.NewRequestWithContext does cause the HTTP body transport to be terminated on a context cancellation. I.e. it is out of control of this codebase anyway; so don't pretend to handle it. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from what
golangci-lintandgopls checkshow. This is not comprehensive, primarily to minimize distractions when working on pkg/chunked.Cc: @giuseppe primarily for a review of the
context.Contextremovals.