Don't discard fields of LayerOptions
#2008
Merged
+3
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of making a copy with some fields, pass the ~deep copy of options we are already using with all of them. Originally motivated by a linter pointing out that the copy of options.BigData has no readers. In some cases it's not entirely clear that we intended the fields to be a public API; at least I can't see any external caller of any of these fields. But now that they _are_ a public API, we can either implement it, or mark the fields as deprecated ... and then we would need to introduce an internal option structure to carry the fields for the call paths where we do want these fields. That's possible but more work, so I'm doing the lazy thing. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
LGTM |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of making a copy with some fields, pass the ~deep copy of options we are already using with all of them.
Originally motivated by a linter pointing out that the copy of
options.BigDatahas no readers.In some cases it's not entirely clear that we intended the fields to be a public API; at least I can't see any external caller of any of these fields. But now that they are a public API, we can either implement it, or mark the fields as deprecated ... and then we would need to introduce an internal option structure to carry the fields for the call paths where we do want these fields. That's possible but more work, so I'm doing the lazy thing.
@giuseppe @nalind PTAL