Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comented out example definition of driver_priority to storage.conf #1987

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

dcermak
Copy link
Contributor

@dcermak dcermak commented Jun 24, 2024

No description provided.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Signed-off-by: Dan Čermák <dcermak@suse.com>
@@ -19,6 +19,10 @@ driver = "overlay"
# Temporary storage location
runroot = "/run/containers/storage"

# Priority list for the storage drivers that will be tested one
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this is a hard coded list and true for all systems.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a hard coded list, it's afaik empty by default (i.e. podman will use it's own logic for picking the driver). This is just an example, hence it's also commented out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually the examples display the defaults, but I am fine with this.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jun 24, 2024

/approve

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented Jun 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcermak, giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Jun 26, 2024

/lgtm
THanks @dcermak

@openshift-ci openshift-ci bot added the lgtm label Jun 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 3b64066 into containers:main Jun 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants