Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create dedicated systemd user service unit #212

Merged
merged 1 commit into from Mar 16, 2024
Merged

create dedicated systemd user service unit #212

merged 1 commit into from Mar 16, 2024

Conversation

rahilarious
Copy link
Contributor

Same systemd service unit file was being used for system and user which works fine for system service but for user service it causes a problem when a user enables the unit. As install target is set to multi-user.target which doesn't exist for user, it prints a warning and doesn't function as expected.

So instead create seperate user service unit, which changes its install target to default.target.

@rahilarious
Add systemd user service...
66be30e 
Same systemd service unit file was being used for system and user which works fine for
system service but for user service it causes a problem when a user enables the
unit. As install target is set to `multi-user.target` which doesn't
exist for user, it prints a warning and doesn't function as expected.

So instead create seperate user service unit, which changes its
install target to `default.target`.

Signed-off-by: Rahil Bhimjiani <me@rahil.rocks>
@rahilarious
Copy link
Contributor Author

Ideally, env file should also be changed from /etc/sysconfig/prometheus-podman-exporter to something which is user accessible like ~/.config/prometheus-podman-exporter.env or similar

@navidys
Copy link
Collaborator

navidys commented Mar 16, 2024

LGTM

@navidys navidys merged commit c60842c into containers:main Mar 16, 2024
33 checks passed
@navidys
Copy link
Collaborator

navidys commented Mar 16, 2024

Ideally, env file should also be changed from /etc/sysconfig/prometheus-podman-exporter to something which is user accessible like ~/.config/prometheus-podman-exporter.env or similar

Hi @rahilarious
#214 will allow to use ~/.config/prometheus-podman-exporter as users environment file.

@rahilarious
Copy link
Contributor Author

Ideally, env file should also be changed from /etc/sysconfig/prometheus-podman-exporter to something which is user accessible like ~/.config/prometheus-podman-exporter.env or similar

Hi @rahilarious #214 will allow to use ~/.config/prometheus-podman-exporter as users environment file.

perfect. Also could you please update go-sqlite to latest? Current version .18 fails build with musl. See mattn/go-sqlite3#1164

@navidys
Copy link
Collaborator

navidys commented Mar 17, 2024

Ideally, env file should also be changed from /etc/sysconfig/prometheus-podman-exporter to something which is user accessible like ~/.config/prometheus-podman-exporter.env or similar

Hi @rahilarious #214 will allow to use ~/.config/prometheus-podman-exporter as users environment file.

perfect. Also could you please update go-sqlite to latest? Current version .18 fails build with musl. See mattn/go-sqlite3#1164

Hi @rahilarious
I don't think I will be able, podman v4.9.3 required go-sqlite3 v1.14.18, it looks like there is a workaround by using CGO_CFLAGS="-D_LARGEFILE64_SOURCE" (passed to go via environment when building).

Next version of exporter (v2.x) which is compatible with podman v5 will use go-sqlite3 v1.14.22.

Regards

@rahilarious
Copy link
Contributor Author

yes. I missed to consider that it is an indirect dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rahilarious @navidys