Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused environment variables in Cirrus #2156

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Oct 24, 2023

Some other containers/* repos use these values in test names; we don't, so remove them so that we don't have to worry about keeping them up to date.

Previously #2150 ; @cevich PTAL to make sure I’m not missing any non-obvious references to these variables.

Some other containers/* repos use these values in test names;
we don't, so remove them so that we don't have to worry
about keeping them up to date.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@@ -29,12 +29,6 @@ env:
# test changes made there, in a PR in this repository.
SKOPEO_PR:

####
#### Cache-image names to test with (double-quotes around names are critical)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the double-quote note be preserved because it still applies to the image names below?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope it's fine to kill that.

Copy link
Member

@cevich cevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg merged commit fefb1f1 into containers:main Oct 24, 2023
10 checks passed
@mtrmac mtrmac deleted the fedora-name branch October 24, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants