Add CNI_NETNS_OVERRIDE for upcoming CNI change #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
approved these changes
Nov 16, 2023
|
@s1061123 looks good, can you squash / remove the merge commit? |
containernetwork/cni#890 introduces CNI_NETNS_OVERRIDE and plugin testing requires this flag. This change enables CNI_NETNS_OVERRIDE for further containernetwork/cni vendor update. Signed-off-by: Tomofumi Hayashi <tohayash@redhat.com>
s1061123
force-pushed
the
fix-netns-override
branch
from
172a396
to
a4cbf13
Compare
|
@squeed done. PTAL again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containernetwork/cni#890 introduces CNI_NETNS_OVERRIDE and plugin testing requires this flag. This change enables CNI_NETNS_OVERRIDE for further containernetwork/cni vendor update.