Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ValidateExpectedRoute with non default routes and nil GW #887

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Fix ValidateExpectedRoute with non default routes and nil GW #887

merged 1 commit into from
Apr 24, 2023

Commits on Apr 20, 2023

  1. Fix ValidateExpectedRoute with non default routes and nil GW 

    Using ptp plugin with non default routes, we get the following error
when cri-o call CheckNetworkList():
```
Expected Route {Dst:{IP:198.18.128.0 Mask:ffff8000} GW:<nil>} not found in routing table
```
Using cniVersion 0.3.1 to bypass the check, we can see that the
route is added with a gateway
```
$ ip r
198.18.0.0/17 via 198.18.0.1 dev eth0 src 198.18.3.102
198.18.0.1 dev eth0 scope link src 198.18.3.102
198.18.128.0/17 via 198.18.0.1 dev eth0
```

If GW is nil only check if we have a route with a DST that matches, and
ignore the GW.

Fixes containernetworking#886
Signed-off-by: Etienne Champetier <e.champetier@ateme.com>
    @champtar
    champtar committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    c347755 View commit details
    Browse the repository at this point in the history