bridge: read only required chain on cni del instead of the entire ruleset #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiqueb
force-pushed
the
mac-spoof-improv-read-only-required-chain-on-cni-del
branch
from
3c0cc97
to
c10c1cf
Compare
maiqueb
changed the title
maiqueb
force-pushed
the
mac-spoof-improv-read-only-required-chain-on-cni-del
branch
from
c10c1cf
to
8b86929
Compare
EdDev
reviewed
Apr 20, 2023
There was a problem hiding this comment.
Thank you!
I had a small suggestion inline, let me know what you think.
Also, please consider using now ReadConfigContext and pass it with a explicit timeout. We could do this in a following PR if you prefer.
BTW, go-nft 0.3.0 is released, so you can use it now.
This go-nft version allows its users to only read particular tables/chains when invoking `ReadConfig`, instead of the entire ruleset. This will make deleting rules from a large ruleset faster, thus speeding up CNI DELs. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2175041 Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb
force-pushed
the
mac-spoof-improv-read-only-required-chain-on-cni-del
branch
from
8b86929
to
6a3eb15
Compare
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb
force-pushed
the
mac-spoof-improv-read-only-required-chain-on-cni-del
branch
from
6a3eb15
to
f793e70
Compare
EdDev
suggested changes
Apr 20, 2023
maiqueb
force-pushed
the
mac-spoof-improv-read-only-required-chain-on-cni-del
branch
from
f793e70
to
ee90f39
Compare
Making sure the exec'ed nft command is executed in 55 secs allows for CNI to fail early, thus preventing CRI from sending another CNI DEL while the previous NFT call is still being processed. This fix prevents part of the behavior described in [0], in which: > cnv-bridge and nft comes pile up in a loop, increasing every 60, never completes The timeout had to be less than 60 seconds (otherwise CRI would still trigger CNI DEL again) but large enough for this feature to have a chance of working on older kernels (e.g. centOS 8), where it takes longer to access even a specific chain/table. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
maiqueb
force-pushed
the
mac-spoof-improv-read-only-required-chain-on-cni-del
branch
from
ee90f39
to
135292e
Compare
squeed
approved these changes
Apr 24, 2023
|
Looks good, thanks for chasing these sorts of performance wins down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
bridge-cnimac spoof protection to only read the required chain on CNI DELs (instead of the entire ruleset). This is required since without it we read the entire ruleset, which takes too long when there are plenty of provisioned rules.It requires an updated version of
go-nft, which also imposes a timeout when trying to read the NFT configuration.These 2 features will hopefully reduce the time it takes to teardown pod networking on CNI DELs.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2175041