Add support for in-container master for macvlans #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s1061123 can you take a look? |
s1061123
reviewed
Jan 24, 2023
Signed-off-by: mmirecki <mmirecki@redhat.com>
mmirecki
force-pushed
the
macvlan_incontainermaster
branch
from
f1bf4cb
to
ac7cf82
Compare
|
It looks good to me, thank you so much for incorporate comments! @squeed I reviewed the PR. Could you please double check that? |
|
Tested both with and without |
|
/lgtm |
|
/lgtm |
|
@squeed does this look good to you now? |
|
@squeed Can you please have a look again? |
squeed
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mmirecki mmirecki@redhat.com