Tap plugin #784
Merged
Tap plugin #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmirecki
force-pushed
the
tap-plugin
branch
4 times, most recently
from
ac1e7ca
to
20b47b6
Compare
maiqueb
reviewed
Nov 21, 2022
maiqueb
reviewed
Nov 21, 2022
mmirecki
force-pushed
the
tap-plugin
branch
6 times, most recently
from
55fa761
to
2c65844
Compare
|
cc: @mccv1r0 too |
mmirecki
force-pushed
the
tap-plugin
branch
2 times, most recently
from
2fc8ec3
to
14ac542
Compare
|
Conceptually it seems good to me! |
s1061123
requested changes
Dec 1, 2022
s1061123
reviewed
Dec 1, 2022
mmirecki
force-pushed
the
tap-plugin
branch
5 times, most recently
from
32a31ff
to
5d37272
Compare
|
NB: The test failure on this PR appears to be unrelated to these changes. Please see #793 for a potential fix. |
Thanks for the tip |
dougbtv
approved these changes
Dec 12, 2022
dcbw
reviewed
Jan 16, 2023
dcbw
reviewed
Jan 16, 2023
mmirecki
force-pushed
the
tap-plugin
branch
3 times, most recently
from
fa2eccd
to
6a616b0
Compare
|
Summarizing some discussion we had in the maintainer's meeting:
|
@squeed Could you please take a look again? |
s1061123
reviewed
Jan 31, 2023
s1061123
requested changes
Feb 2, 2023
maiqueb
reviewed
Feb 6, 2023
mmirecki
force-pushed
the
tap-plugin
branch
2 times, most recently
from
f8bb33f
to
81307ea
Compare
|
I'm OK with the updates WRT selinux stuff and the /sbin/ip vs. netlink issues. |
|
@squeed how about now? |
maiqueb
reviewed
Feb 6, 2023
maiqueb
approved these changes
Feb 6, 2023
|
@squeed Can you please have a look again? |
squeed
approved these changes
Feb 13, 2023
This PR adds a plugin to create tap devices. The plugin adds a tap device to the container. The plugin has a workaround for a golang netlink library which does not allow for tap devices with no owner/group to be created. When no tap owner/group is requested, the plugin will fall back to using the ip tool for creating the tap device. A fix to the golang netlink lib is pending. Signed-off-by: mmirecki <mmirecki@redhat.com>
dcbw
approved these changes
Feb 13, 2023
fahedouch
reviewed
May 10, 2023
| } | ||
| } | ||
|
|
||
| func createTap(conf *NetConf, ifName string, netns ns.NetNS) (*current.Interface, error) { |
There was a problem hiding this comment.
Hi @mmirecki,
thank you for your greate job. Is it possible to export this func we may need to refacto container rootlesskit code. If LGTY I can take care thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a plugin to create tap devices.
The plugin adds a tap device to the container.
The plugin has a workaround for a golang netlink library
which does not allow for tap devices with no owner/group
to be created. When no tap owner/group is requested, the
plugin will fall back to using the ip tool for creating
the tap device. A fix to the golang netlink lib is pending:
vishvananda/netlink#835