add more tests

Signed-off-by: Date Huang <tjjh89017@hotmail.com>
containernetworking · Apr 19, 2023 · beae87d · beae87d
1 parent e642eb8
commit beae87d
Showing 1 changed file with 24 additions and 4 deletions.
diff --git a/plugins/main/bridge/bridge_test.go b/plugins/main/bridge/bridge_test.go
@@ -1765,10 +1765,13 @@ var _ = Describe("bridge Operations", func() {
 	})
 
 	var (
-		correctMinID int = 100
-		correctMaxID int = 105
-		overID       int = 5000
-		negativeID   int = -1
+		correctID      int = 10
+		correctMinID   int = 100
+		correctMaxID   int = 105
+		incorrectMinID int = 1000
+		incorrectMaxID int = 100
+		overID         int = 5000
+		negativeID     int = -1
 	)
 
 	DescribeTable(
@@ -1783,6 +1786,20 @@ var _ = Describe("bridge Operations", func() {
 				MaxID: &correctMaxID,
 			},
 		}, []int{100, 101, 102, 103, 104, 105}),
+		Entry("when provided a VLAN trunk configuration with id only", []*VlanTrunk{
+			{
+				ID: &correctID,
+			},
+		}, []int{10}),
+		Entry("when provided a VLAN trunk configuration with id and range", []*VlanTrunk{
+			{
+				ID: &correctID,
+			},
+			{
+				MinID: &correctMinID,
+				MaxID: &correctMaxID,
+			},
+		}, []int{10, 100, 101, 102, 103, 104, 105}),
 	)
 
 	DescribeTable(
@@ -1797,6 +1814,9 @@ var _ = Describe("bridge Operations", func() {
 		Entry("when the minID is larger than 4094", []*VlanTrunk{{MinID: &overID, MaxID: &correctMaxID}}, fmt.Errorf("incorrect trunk minID parameter")),
 		Entry("when the maxID is larger than 4094", []*VlanTrunk{{MinID: &correctMinID, MaxID: &overID}}, fmt.Errorf("incorrect trunk maxID parameter")),
 		Entry("when the maxID is negative", []*VlanTrunk{{MinID: &correctMinID, MaxID: &overID}}, fmt.Errorf("incorrect trunk maxID parameter")),
+		Entry("when the ID is larger than 4094", []*VlanTrunk{{ID: &overID}}, fmt.Errorf("incorrect trunk id parameter")),
+		Entry("when the ID is negative", []*VlanTrunk{{ID: &negativeID}}, fmt.Errorf("incorrect trunk id parameter")),
+		Entry("when the maxID is smaller than minID", []*VlanTrunk{{MinID: &incorrectMinID, MaxID: &incorrectMaxID}}, fmt.Errorf("minID is greater than maxID in trunk parameter")),
 	)
 
 	for _, ver := range testutils.AllSpecVersions {