-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go.{mod,sum}, .github: bump minimum golang version to 1.20. #88
Conversation
klihub
commented
Jun 4, 2024
•
edited
Loading
edited
- bump minimum golang version to 1.20
- test using 1.20, 1.21, and 1.22 in CI
- bump setup-go to v5
- update golangci-lint and fix related linter errors
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c7ceb92
to
97e834b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green
4508eec
to
8a9d653
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 64.55% 63.98% -0.57%
==========================================
Files 10 4 -6
Lines 1845 1305 -540
==========================================
- Hits 1191 835 -356
+ Misses 503 356 -147
+ Partials 151 114 -37 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
8a9d653
to
2c3608d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM