[release/1.7] Include userns info in PodSandboxStatus #9865
Conversation
|
Hi @rata. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Looks like you have the change in sbserver but the tests still in server. Is the intent to make the change in both server and sbserver or just have the tests updated in sbserver? |
rata
force-pushed
the
rata/userns-update-podSandboxStatus-1.7
branch
from
792dd49
to
396a853
Compare
|
@dmcgowan haha, sorry! I realized about that, fixed it, and then forgot to push 🙈. Pushed now (validated locally in a cluster too :)) |
rata
force-pushed
the
rata/userns-update-podSandboxStatus-1.7
branch
2 times, most recently
from
3240524
to
462b59c
Compare
We added support for userns but we weren't showing it in the podSandboxStatus. Let's just show the whole nsOpts, so we don't forget in the future either if something else inside there changes. Please note that this will expose the content of nsOpts.TargetId that we weren't exposing before. But that seemed like a bug to me. The cherry-pick has been amended to do the change in cri/sbserver and cri/server. Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com> (cherry picked from commit 6c356a5)
rata
force-pushed
the
rata/userns-update-podSandboxStatus-1.7
branch
2 times, most recently
from
9142d8d
to
e78f153
Compare
The cherry-pick has been amended to duplicate the tests in cri/sbserver and cri/server. Signed-off-by: Rodrigo Campos <rodrigoca@microsoft.com> (cherry picked from commit 06ed897)
rata
force-pushed
the
rata/userns-update-podSandboxStatus-1.7
branch
from
e78f153
to
b57dc9f
Compare
dmcgowan
changed the title
This is a backport of #9782. It applies cleanly, but the cherry-picks have been amended to do the change in cri/server and cri/sbserver.
We added support for userns but we weren't showing it in the
PodSandboxStatus.
Let's just show the whole nsOpts, so we don't forget in the future
either if something else inside there changes.
Please note that this will expose the content of nsOpts.TargetId that we
weren't exposing before. But that seemed like a bug to me.