Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.7] Register imagePullThroughput and count with MiB #9855

Merged
merged 1 commit into from
Mar 1, 2024
Merged

[release/1.7] Register imagePullThroughput and count with MiB #9855

merged 1 commit into from
Mar 1, 2024

Conversation

ialidzhikov
Copy link

/kind bug

Cherry-pick of #8337 into release/1.7 branch.

@k8s-ci-robot
Copy link

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ialidzhikov ialidzhikov mentioned this pull request Feb 22, 2024
Merged
@ialidzhikov
Copy link
Author

/assign @dmcgowan @fuweid @dcantah

@ialidzhikov ialidzhikov changed the title Register imagePullThroughput and count with MiB [release/1.7] Register imagePullThroughput and count with MiB Feb 22, 2024
@ialidzhikov ialidzhikov mentioned this pull request Feb 22, 2024
Open
97 tasks
@fuweid
Copy link
Member

fuweid commented Feb 22, 2024

Would you please use git cherry-pick -xs ? thanks!

@ialidzhikov ialidzhikov force-pushed the cherry-pick-8337-to-release/1.7 branch from 9f2dc1f to 75679a5 Compare February 23, 2024 07:25
@ialidzhikov
Copy link
Author

Would you please use git cherry-pick -xs ? thanks!

Done. PTAL.

@fuweid fuweid mentioned this pull request Feb 25, 2024
Merged
@fuweid
Copy link
Member

fuweid commented Feb 26, 2024

@ialidzhikov I fixed the ci issue by #9874. Please rebase and push it again. Thanks!

@ialidzhikov
Register imagePullThroughput and count with MiB
711cebd 
Signed-off-by: Shukui Yang <yangshukui@bytedance.com>
(cherry picked from commit db22327)
@ialidzhikov ialidzhikov force-pushed the cherry-pick-8337-to-release/1.7 branch from 75679a5 to 711cebd Compare February 26, 2024 07:32
@ialidzhikov
Copy link
Author

@ialidzhikov I fixed the ci issue by #9874. Please rebase and push it again. Thanks!

Done.

@dmcgowan dmcgowan merged commit 33b3e13 into containerd:release/1.7 Mar 1, 2024
54 checks passed
@dmcgowan dmcgowan mentioned this pull request Mar 8, 2024
Merged
@ialidzhikov ialidzhikov deleted the cherry-pick-8337-to-release/1.7 branch March 14, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@dcantah dcantah dcantah approved these changes

Assignees

@dmcgowan dmcgowan

@fuweid fuweid

@dcantah dcantah

Labels
impact/changelog kind/bug needs-ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ialidzhikov @k8s-ci-robot @fuweid @dmcgowan @dcantah