Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/1.7] Don't block snapshot garbage collection on Remove failures #9482

Merged
merged 1 commit into from
Dec 8, 2023
Merged

[release/1.7] Don't block snapshot garbage collection on Remove failures #9482

merged 1 commit into from
Dec 8, 2023
+3 −1

Commits on Dec 7, 2023

  1. Don't block snapshot garbage collection on Remove failures 

    If a snapshot removal fails (during garbage collection), the entire garbage collection operation is
cancelled. This is problematic because once cleanup of any snapshot fails no other snapshots will be cleaned
and the disk usage will just keep increasing.
Solution is to return snapshot removal errors wrapped as "ErrFailedPrecondition" errors. The garbage
collectors continues cleanup if the error is of this type.

Signed-off-by: Amit Barve <ambarve@microsoft.com>
(cherry picked from commit ad96fde)
Signed-off-by: Amit Barve <ambarve@microsoft.com>
    @ambarve
    ambarve committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    ed7c689 View commit details
    Browse the repository at this point in the history