[release/1.7] tasks: emit warning for v1 runtime and runc v1 runtime

[samuelkarp]

Part of #9312

$ sudo bin/ctr deprecations list
ID                                           LAST OCCURRENCE                   MESSAGE    
io.containerd.deprecation/runtime-v1         2023-12-01T07:26:57.614014991Z    The `io.containerd.runtime.v1.linux` runtime is deprecated since containerd v1.4 and removed in containerd v2.0. Use the `io.containerd.runc.v2` runtime instead.
io.containerd.deprecation/runtime-runc-v1    2023-12-01T07:27:34.505898489Z    The `io.containerd.runc.v1` runtime is deprecated since containerd v1.4 and removed in containerd v2.0. Use the `io.containerd.runc.v2` runtime instead.

[fuweid]

LGTM

[ruiwen-zhao]

so we are only emitting warnings for io.containerd.runtime.v1.linux. Are we not deprecating other v1 runtimes like io.containerd.runtime.v1.windows?

[samuelkarp]

That's a good question. Does io.containerd.runtime.v1.windows exist? I see it in a couple places in the client code (1, 2, 3) but can't find the actual plugin implementing it. @dcantah do you know?

[laurazard]

LGTM

[samuelkarp]

/cherrypick release/1.6

[k8s-infra-cherrypick-robot]

@samuelkarp: #9450 failed to apply on top of branch "release/1.6":

Applying: tasks: emit warning for v1 runtime
Using index info to reconstruct a base tree...
M	pkg/deprecation/deprecation.go
M	services/tasks/local.go
M	services/tasks/local_darwin.go
M	services/tasks/local_unix.go
Falling back to patching base and 3-way merge...
Auto-merging services/tasks/local_unix.go
Auto-merging services/tasks/local_darwin.go
Auto-merging services/tasks/local.go
CONFLICT (content): Merge conflict in services/tasks/local.go
Auto-merging pkg/deprecation/deprecation.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 tasks: emit warning for v1 runtime
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release/1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.